-
Notifications
You must be signed in to change notification settings - Fork 71
Use prebuilt protoc #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use prebuilt protoc #443
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ module( | |
| bazel_dep(name = "rules_java", version = "9.0.3") | ||
| bazel_dep(name = "bazel_skylib", version = "1.8.1") | ||
| bazel_dep(name = "rules_jvm_external", version = "6.7") | ||
| bazel_dep(name = "protobuf", version = "33.4", repo_name = "com_google_protobuf") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this necessary? Apps shouldn't need to declare dependencies that are used by the rules. |
||
|
|
||
| bazel_dep( | ||
| name = "rules_android", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,7 +98,7 @@ java_library( | |
| "@rules_android_maven//:com_google_code_findbugs_jsr305", | ||
| "@rules_android_maven//:com_google_errorprone_error_prone_annotations", | ||
| "@rules_android_maven//:com_google_guava_guava", | ||
| "@rules_android_maven//:com_google_protobuf_protobuf_java", | ||
| "@com_google_protobuf//java/core", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need protobuf in the Maven deps if you're replacing their references with |
||
| ":android_common_30_1_3", | ||
| ":android_databinding_wrapper_lib", | ||
| ":android_options_utils", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another way to pass this flag to the underlying proto rules/actions? This line assumes that the user's app depends on protobuf directly, which might not be the case.