Do not include libraries when compiling #3801
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, when in experimental_use_cc_common_link mode, we no longer include linker, runtime libraries, and any transitive libraries to link in the rustc compilation action. This makes incremental rebuilds faster by not recompiling when once of those linker inputs changes.
Collaborator
|
Looks reasonable, but let's see what we can do about the busted CI as that looks like it might be shadowing some test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, when in experimental_use_cc_common_link mode, we no longer include linker, runtime libraries, and any transitive libraries to link in the rustc compilation action. This makes incremental rebuilds faster by not recompiling when once of those linker inputs changes.