Remove videoFramesNotAdvancing feature #108
Open
+4
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Removes
videoFramesNotAdvancingfeature from Dash.js. This used the uncertified Video Quality API. The varying performance across devices of this interface led to a number of false positives.This combined with the addition of a
lowLatencyStallThresholdnow in mainline Dash.js and the resolution of the underlying Chrome bug that led to this workaround mean we can now safely remove this feature.🛠 How
PLAYBACK_FROZENevent from the event bus.P00error from DVB reporting.videoFramesNotAdvancingfunction from theSreamControllerand associated helper functionsvideoFramesNotAdvancing