[WIP] added connected callback#2
Open
ChrisBAshton wants to merge 1 commit intobbc:masterfrom
ChrisBAshton:connected_callback
Open
[WIP] added connected callback#2ChrisBAshton wants to merge 1 commit intobbc:masterfrom ChrisBAshton:connected_callback
ChrisBAshton wants to merge 1 commit intobbc:masterfrom
ChrisBAshton:connected_callback
Conversation
i.e. added a way of auto-passing information from the host to the child
EdwardLuke
pushed a commit
that referenced
this pull request
Feb 15, 2018
…embedded_or_not Put a class on html for whether the child is embedded, or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened a PR from my pym.js fork of this one.
DO NOT MERGE yet - await the outcome of https://github.com/bbc/news-vj-developer-scaffold-iframe-wrapper/pull/30.
Pym.js
BBC-specific modifications
configproperty with whatever you like (e.g. host URL, cookies, etc)connectedCallbackfunction, which is invoked once a connection has been made with the pym Parent.Example:
...and the child: