Skip to content

Updated helm reference to new tusd_py3 docker image, the image contai… #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimOsse wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated helm reference to new tusd_py3 docker image, the image contai… #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bd43bc
Updated helm reference to new tusd_py3 docker image, the image contai…
TimOsse Jan 25, 2023
137b825
request_api test failure fix 1
TimOsse Jan 25, 2023
b1abd92
request_api test failure fix 2
TimOsse Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ocwa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,12 @@ jobs:
mkdir ${PWD}/mongodb-linux-x86_64-${MONGODB}/data
${PWD}/mongodb-linux-x86_64-${MONGODB}/bin/mongod --dbpath ${PWD}/mongodb-linux-x86_64-${MONGODB}/data --logpath ${PWD}/mongodb-linux-x86_64-${MONGODB}/mongodb.log --fork
${PWD}/mongodb-linux-x86_64-${MONGODB}/bin/mongo forumDb --eval 'db.createUser({user:"forumUser", pwd:"forumPass", roles:["dbAdmin", "readWrite"]});'
${PWD}/mongodb-linux-x86_64-${MONGODB}/bin/mongorestore -u forumUser -p forumPass -d forumDb db
cd ../shared/js
npm ci

cd ../../formio
mongorestore -u forumUser -p forumPass -d forumDb db

git clone -b v1.90.15 https://github.com/formio/formio.git
cd formio
npm ci
Expand Down
2 changes: 1 addition & 1 deletion microservices/storageApi/helm/storage-api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ image:
pullPolicy: Always

tus:
image: h3brandon/tusd_py3
image: tosse/tusd_py3
Copy link

@adodge-bcg adodge-bcg Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the helm chart that is used in the deploy?
From what I remember, most of brandons helm charts got moved to https://github.com/bcgov/helm-charts

Copy link

@adodge-bcg adodge-bcg Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgov/helm-charts/tree/master/charts/storage-api

Copy link
Author

@TimOsse TimOsse Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, I am not sure which one is being used. I have no documentation on the deployment.

Copy link
Author

@TimOsse TimOsse Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This storage-api microservice has not been modified in 3 years while the helm-charts version was last modified 2 years ago. So have made the same change to the helm-chart version, and i will have a PR for review momentarily.

tag: latest
bucket: bucket
region: us-east-1 #likely irrelevant
Expand Down