PSP-7782 : Document Manager: document selection and uploading -MP(UI ONLY)#5245
PSP-7782 : Document Manager: document selection and uploading -MP(UI ONLY)#5245eddherrera wants to merge 3 commits intobcgov:devfrom
Conversation
eddherrera
commented
Mar 6, 2026
eddherrera
commented
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
source/frontend/src/features/documents/documentUpload/DocumentUploadForm.test.tsx
Fixed
Show fixed
Hide fixed
...c/features/documents/documentUpload/documentUploadReplace/DocumentUploadReplaceView.test.tsx
Fixed
Show fixed
Hide fixed
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5245 |
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5245 |
asanchezr
left a comment
asanchezr
left a comment
There was a problem hiding this comment.
LGTM - just minor comments.
Also could you please confirm that the "replace" icons were approved by Jordan?
The story is talking about using a link with text "Replace File" so it would be good to update the story with ACs so FT team doesn't fail these changes
|
|
||
| // get the upload button | ||
| const uploader = getByTestId('upload-input'); | ||
| console.log(uploader); |
There was a problem hiding this comment.
please remove console.log
| <Col md="2"> | ||
| <Button | ||
| title="cancel-replace" | ||
| variant={'secondary'} |
There was a problem hiding this comment.
nit: please use regular strings here
| variant={'secondary'} | |
| variant="secondary" |
| <Col md="2"> | ||
| <Button | ||
| title="confirm-replace" | ||
| variant={'primary'} |
There was a problem hiding this comment.
| variant={'primary'} | |
| variant="primary" |
| data-testid="ok-replace-button" | ||
| disabled={!exists(file)} | ||
| > | ||
| {'Replace'} |
There was a problem hiding this comment.
| {'Replace'} | |
| Replace |
2 participants
