Skip to content

Conversation

@JazzarKarim
Copy link
Collaborator

Issue:

Description of changes:

  • Look in the registrations_json, if the initiatedByPropertyManager is found, store it in the registration under property manager

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@JazzarKarim JazzarKarim requested a review from dimak1 February 10, 2026 23:31
@JazzarKarim JazzarKarim self-assigned this Feb 10, 2026
@JazzarKarim
Copy link
Collaborator Author

@dimak1 @thorwolpert So i found something really interesting. That initiatedByPropertyManager field is populated in the registration_json across ALL registrations. This was done collaterally by the backfiller job that I ran last week. I'm thinking this might fix our problem for CURRENT & OLD registrations. Thoughts?

@thorwolpert
Copy link
Collaborator

You should use | None instead of Optional[] going forward.

@sonarqubecloud
Copy link

@JazzarKarim JazzarKarim merged commit 5746da3 into bcgov:main Feb 10, 2026
11 of 12 checks passed
@dimak1
Copy link
Collaborator

dimak1 commented Feb 10, 2026

@JazzarKarim good news if it fixes it. I also found a workaround for PMs during the renewals, so we should be good for now. It is in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants