Skip to content

Conversation

@dgboss
Copy link
Collaborator

@dgboss dgboss commented Dec 30, 2025

Moves the old wildfire_fetchers.py code into a separate module with tests.

Closes: #4961

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 94.82440% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.82%. Comparing base (75f7ea7) to head (722e646).

Files with missing lines Patch % Lines
...wps-shared/src/wps_shared/wildfire_one/wfwx_api.py 78.66% 15 Missing and 1 partial ⚠️
...src/wps_shared/tests/wildfire_one/test_wfwx_api.py 97.71% 5 Missing and 5 partials ⚠️
...packages/wps-shared/src/wps_shared/tests/common.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4983      +/-   ##
==========================================
+ Coverage   74.86%   75.82%   +0.95%     
==========================================
  Files         587      586       -1     
  Lines       27610    27858     +248     
  Branches     2045     2038       -7     
==========================================
+ Hits        20671    21123     +452     
+ Misses       6360     6147     -213     
- Partials      579      588       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all wf1 code should go in the new wps-wf1 package otherwise we have 2 places where wf1 code lives.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 31, 2025

Quality Gate Passed Quality Gate passed

Issues
12 New issues
36 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor WF1 related code out of wps-api into a separate package

3 participants