Closed
Conversation
demurgos
suggested changes
Aug 2, 2018
test/integration.js
Outdated
| describe('c8', () => { | ||
| it('reports coverage for script that exits normally', () => { | ||
| const {output} = spawnSync(c8Path, [ | ||
| const {output} = spawnSync('node', [ |
Contributor
There was a problem hiding this comment.
It should use process.execPath instead of node.
As is, this would fail if node is not in the PATH. (It may also cause subtle bugs if there are multiple versions of Node)
Contributor
Author
There was a problem hiding this comment.
Thanks! fixed.
laggingreflex
force-pushed
the
fix/windows
branch
from
a629192 to
37744f9
Compare
demurgos
approved these changes
Aug 2, 2018
demurgos
added a commit
to demurgos/c8
that referenced
this pull request
Aug 19, 2018
This is a relatively large commit to update the project to use Typescript. The main benefit is documentation. By annotating the expected type for most values, it can be checked statically and help new maintainers to be confident with their changes. Beyond this, it brings the benefits of type definitions to consumers of the library (completion, type checking, etc). This first commit does not do any change in the behavior of the code, it does not even type anything. It just adds Typescript and converts the files. It adds `tslint` as a linter. This commit still results in lint errors but they will be fixed in a subsequent commit. Even at this minimal stage, it caught a few errors: - `JSON.parse` received a `Buffer` instead of a `string` in `parse-arg.js` line 8. - In the integrations tests, it tried to strinfy the `output` field as if was the `stdout` buffer (but it is an array of buffers for the standard streams) - `bin/c8.js` had to be executable when running the tests. This breaks on Windows Closes bcoe#17
Owner
|
@laggingreflex see #22 let's fix some of the outstanding issues once we switch to using Node's built in coverage 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.