set defaults for settings, and respect max_frame_size in sending#7
set defaults for settings, and respect max_frame_size in sending#7kahuang wants to merge 1 commit intobdarnell:masterfrom
Conversation
|
I'm using this http2 server as a same-process testing server for a tornado based http2 client. For large body values, the server wasn't respecting the max frame size, causing errors on the client side:
This PR solves that issue by ensuring that 1. We have our settings initialized as the defaults and 2. We respect the MAX_FRAME_SIZE setting |
bdarnell
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you add a test that runs into this problem? Probably a version of ServerTest.test_large_response that writes its payload all at once instead of in small chunks.
|
I've added a test that writes the payload all at once, instead of in chunks. |
responses to clients