Skip to content

fix: [GH-689] Creating Empty Embed #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beanbeanjuice merged 1 commit into from
Feb 4, 2026
Merged

fix: [GH-689] Creating Empty Embed #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/main/java/com/beanbeanjuice/cafebot/commands/generic/EmbedCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,18 @@ public void handle(SlashCommandInteractionEvent event) {
return;
}

Optional<MessageEmbed> optionalEmbed = createEmbed(event);

if (optionalEmbed.isEmpty()) {
event.getHook().sendMessageEmbeds(Helper.errorEmbed("Invalid Embed", "You're trying to create an invalid embed... I'm so sorry I can't let you do that...")).queue();
return;
}

MessageEmbed embed = optionalEmbed.get();

messageOptional.ifPresentOrElse(
(message) -> channel.asTextChannel().sendMessage(message).addEmbeds(createEmbed(event)).queue(),
() -> channel.asTextChannel().sendMessageEmbeds(createEmbed(event)).queue()
(message) -> channel.asTextChannel().sendMessage(message).addEmbeds(embed).queue(),
() -> channel.asTextChannel().sendMessageEmbeds(embed).queue()
);

event.getHook().sendMessageEmbeds(Helper.successEmbed(
Expand All @@ -66,7 +75,7 @@ private boolean checkValidImages(final @Nullable Message.Attachment thumbnail, f
return true;
}

private MessageEmbed createEmbed(final SlashCommandInteractionEvent event) {
private Optional<MessageEmbed> createEmbed(final SlashCommandInteractionEvent event) {
Optional<String> titleOptional = Optional.ofNullable(event.getOption("title")).map(OptionMapping::getAsString);
Optional<String> descriptionOptional = Optional.ofNullable(event.getOption("description")).map(OptionMapping::getAsString);
Optional<String> authorOptional = Optional.ofNullable(event.getOption("author")).map(OptionMapping::getAsString);
Expand Down Expand Up @@ -94,7 +103,11 @@ private MessageEmbed createEmbed(final SlashCommandInteractionEvent event) {
})
.ifPresent(embedBuilder::setColor);

return embedBuilder.build();
try {
return Optional.of(embedBuilder.build());
} catch (IllegalStateException e) {
return Optional.empty();
}
}

@Override
Expand Down
Loading