changing gameId parsing to remove day_{xx}#114
Open
james-ingold wants to merge 1 commit intobeanumber:masterfrom
Open
changing gameId parsing to remove day_{xx}#114james-ingold wants to merge 1 commit intobeanumber:masterfrom
james-ingold wants to merge 1 commit intobeanumber:masterfrom
Conversation
This was referenced Mar 30, 2018
Open
Owner
|
@gjm112 can you handle this? It looks simple enough but I don't have time to test it right now. |
Collaborator
|
I'll try to do this tonight.
…On Tue, Apr 3, 2018 at 10:28 AM, Ben Baumer ***@***.***> wrote:
@gjm112 <https://github.com/gjm112> can you handle this? It looks simple
enough but I don't have time to test it right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#114 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGUpfzJ5kCU9IjsH9wSc0d_UtNTeGUCks5tk5UXgaJpZM4TB3Cs>
.
--
Gregory J. Matthews, Ph.D.
Assistant Professor
Department of Mathematics and Statistics
Loyola University Chicago
E-mail: gjm112 -at- gmail.com
Blog: StatsInTheWild.com
Art: etsy.me/1JAsYz9
Twitter: @statsinthewild <http://www.twitter.com/StatsInTheWild>
Twitter: @StatsClass <http://www.twitter.com/statsclass>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like MLB gameday has changed the game ids in their anchor tags. The urls from game day are including the day_xx portion of the url in the gameid now, this is causing an issue in getUrls where it tries to parse out the year, month, and date. readData was returning 404s due to this issue.