Open
Conversation
11d30f8 to
f5cc4bd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@wakonig what do you think of this? Doesn't look like it requires too many changes, but if we want to do it we should before anyone starts writing user scripts that access readings |
Member
|
I like it! - Let's postpone it to V4 though. I'm also preparing a few breaking changes atm |
Contributor
Author
|
Sounds good, I'll try to keep it up to date. @cappel89 @wyzula-jan try to write things that use the device @wakonig should we start a v4 release branch soon then? |
Member
Yes, if you want, you can already create a pre_release_v4 branch and we merge it |
769afe0 to
b274185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #564