Skip to content

fix: allow setting config to empty but not None #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-perl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow setting config to empty but not None #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bec_lib/bec_lib/config_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,10 @@ def send_config_request(
Returns: request ID (str)

"""
if action in ["update", "add", "set"] and not config:
if action in ["update", "add"] and not config:
raise DeviceConfigError(f"Config cannot be empty for an {action} request.")
if action == "set":
config = config or {} # coerce None
RID = str(uuid.uuid4())
self.connector.send(
MessageEndpoints.device_config_request(),
Expand Down
Loading