Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
d-perl
force-pushed
the
feat/device_locking
branch
2 times, most recently
from
b7a9ca3 to
3fe21c6
Compare
d-perl
force-pushed
the
feat/device_locking
branch
from
3fe21c6 to
d68f406
Compare
d-perl
force-pushed
the
feat/device_locking
branch
from
05dbda1 to
2ab5bec
Compare
d-perl
force-pushed
the
feat/device_locking
branch
from
2ab5bec to
3a58dbe
Compare
wakonig
reviewed
Feb 3, 2026
| devices_to_lock = [] | ||
| else: | ||
| devices_to_lock = scan_instance.instance_device_access().device_locking | ||
| with self.parent.device_locks.lock(devices_to_lock): |
Member
There was a problem hiding this comment.
is the change here merely an indentation due to the context manager? GH diff is a bit confusing...
Contributor
Author
There was a problem hiding this comment.
yes, it's just indented one level deeper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a lock manager to the scan server to manages sharing of devices
Initial implementation only blocks while waiting for locks but lock manager has the required functionality to check and raise instead