BEC Messages Refactor 1: mark all message dicts as jsonable#762
Draft
BEC Messages Refactor 1: mark all message dicts as jsonable#762
Conversation
d-perl
force-pushed
the
refactor/improve_message_typing
branch
9 times, most recently
from
71c56e5 to
1dce098
Compare
d-perl
force-pushed
the
refactor/improve_message_typing
branch
from
1dce098 to
ce76ee2
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
d-perl
changed the title
d-perl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To facilitate migrating to a language-agnostic messaging structure, we should avoid use of custom types in unstructured data. This is step one towards that goal: annotating all
dict[unknown, unknown]as JSON/msgpack compatible types, and ignoring numpy types for now. This change introduces a substantial performance penalty which will be removed in the next iteration when we can rely on only the in-rust part of pydantic validation and not the many python checks on each object in a dictionary. The next step is to replace all numpy-containing objects with structured pydantic models and refactor the code base to support this, which mostly already exists in #761 but will be tidier on this base. It will require some small changes to BW and OD.