Skip to content

Comments

Feature/scan info metadata#1002

Open
wakonig wants to merge 7 commits intopre_release_v3from
feature/scan_info_metadata
Open

Feature/scan info metadata#1002
wakonig wants to merge 7 commits intopre_release_v3from
feature/scan_info_metadata

Conversation

@wakonig
Copy link
Member

@wakonig wakonig commented Jan 10, 2026

Description

This PR moves the scan metadata into a group box, slightly adjusts the spacing and assigns label

Additional Comments

We need to adapt the scan queue widget to show the scan metadata. Can be done in a follow-up PR.

image

Definition of Done

  • Documentation is up-to-date.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ets/widgets/editors/scan_metadata/scan_metadata.py 38.46% 6 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@wakonig wakonig marked this pull request as ready for review January 12, 2026 13:53
Copilot AI review requested due to automatic review settings January 12, 2026 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the scan metadata user interface by organizing metadata fields into a labeled group box with adjusted spacing, and improves form usability by displaying field titles and descriptions as labels and placeholders.

Changes:

  • Wrapped scan metadata form in a "Scan Metadata" group box for better visual organization
  • Added automatic population of scan_name field with current scan name when empty
  • Enhanced form labels to use Pydantic field titles when available
  • Added field descriptions as placeholder text in string input fields

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
bec_widgets/widgets/editors/scan_metadata/scan_metadata.py Adjusted margins, added logic to populate scan_name field with current scan, and default empty scan_name to current scan in form data
bec_widgets/widgets/control/scan_control/scan_control.py Wrapped metadata form in QGroupBox with "Scan Metadata" label for better UI organization
bec_widgets/utils/forms_from_types/items.py Added field description as placeholder text for string input fields
bec_widgets/utils/forms_from_types/forms.py Changed form labels to use Pydantic field title instead of field name when available

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@d-perl
Copy link
Contributor

d-perl commented Jan 12, 2026

I pushed a commit which should fix the tests so that they will work with the changes in bec-project/bec#727

Copy link
Contributor

@cappel89 cappel89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

One comment about a potential additional improvement to add a tooltip is attached. Besides that, I realized that the size policy of the widget is a bit messed up. This is unrelated to this PR, but as this increases the required vertical size, it has come to my attention now. I attach a screenshot:

Image

@wakonig wakonig force-pushed the feature/scan_info_metadata branch from 801e17d to a8ccbf2 Compare January 15, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants