Conversation
d-perl
force-pushed
the
fix/client_mock_hacks
branch
9 times, most recently
from
b837c12 to
e1fcb74
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d-perl
force-pushed
the
fix/client_mock_hacks
branch
from
e1fcb74 to
3f1dcf8
Compare
d-perl
force-pushed
the
fix/client_mock_hacks
branch
3 times, most recently
from
a3794a2 to
5ea90f8
Compare
d-perl
force-pushed
the
fix/client_mock_hacks
branch
from
0b6b49b to
f2d40f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of the client mocks for better organisation, correctness, and maybe performance
This is a foundation for further improvements on the test suite by possibly introducting a global reusable client (which will improve performance but we will need to watch out for state leaking), getting rid of individual fakeredis instantiations, etc.