Skip to content

Comments

Change device_name/entry to device/signal#1049

Open
wyzula-jan wants to merge 1 commit intopre_release_v3from
refactor/device-signal-names
Open

Change device_name/entry to device/signal#1049
wyzula-jan wants to merge 1 commit intopre_release_v3from
refactor/device-signal-names

Conversation

@wyzula-jan
Copy link
Contributor

@wyzula-jan wyzula-jan commented Feb 2, 2026

Description

Unify the naming conventions for device-signal pairs according to agreed in #1036. Additionally dropping "next_gen" from tests since there is only one version of the widget.

Related Issues

-closes #1036

@wyzula-jan wyzula-jan self-assigned this Feb 2, 2026
@wyzula-jan wyzula-jan force-pushed the refactor/device-signal-names branch from 0b85f8c to 89995ea Compare February 3, 2026 15:52
@wyzula-jan wyzula-jan force-pushed the refactor/device-signal-names branch from 89995ea to 7dcc45f Compare February 3, 2026 16:07
@wyzula-jan wyzula-jan marked this pull request as ready for review February 3, 2026 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the naming conventions for device-signal pairs throughout the bec_widgets codebase, changing from device_name/entry (or variants like x_device_name/x_device_entry) to device/signal (or device_x/signal_x, device_y/signal_y, etc.). This unifies the nomenclature according to the agreement in issue #1036. Additionally, "next_gen" suffixes are removed from test file names.

Changes:

  • Renamed all device-signal pair parameters and properties from *_name/*_entry to device_*/signal_* pattern
  • Updated model field names in DeviceSignal, ScatterDeviceSignal, HeatmapDeviceSignal, and MotorConfig
  • Updated UI files (.ui) to reflect new widget naming
  • Updated all tests, documentation, and RPC client stubs to match new naming
  • Removed "next_gen" from test file names

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/unit_tests/test_waveform.py Updated test assertions for DeviceSignal field names (name→device, entry→signal)
tests/unit_tests/test_scatter_waveform.py Updated ScatterWaveform test parameter names and property assertions
tests/unit_tests/test_motor_map_next_gen.py Renamed from "_next_gen", updated MotorConfig field names
tests/unit_tests/test_image_view_next_gen.py Renamed from "_next_gen", updated Image widget parameter names
tests/unit_tests/test_heatmap_widget.py Updated Heatmap parameter names and SafeProperty names
tests/unit_tests/test_curve_settings.py Updated curve tree test parameter names
tests/end-2-end/*.py Updated all e2e tests with new parameter names
docs/**/*.md Updated documentation examples with new parameter names
bec_widgets/widgets/plots/waveform/* Updated Waveform widget parameters, properties, and internal usage
bec_widgets/widgets/plots/scatter_waveform/* Updated ScatterWaveform parameters, config fields, and properties
bec_widgets/widgets/plots/motor_map/* Updated MotorMap config and parameters
bec_widgets/widgets/plots/image/* Updated Image widget parameters and properties
bec_widgets/widgets/plots/heatmap/* Updated Heatmap parameters, config, properties, and UI files
bec_widgets/cli/client.py Updated RPC stub signatures
bec_widgets/widgets/containers/auto_update/auto_updates.py Updated auto-update widget calls
bec_widgets/applications/views/view.py Updated view widget parameter usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wyzula-jan wyzula-jan force-pushed the refactor/device-signal-names branch 2 times, most recently from 171dfe8 to 37c93d3 Compare February 16, 2026 19:34
@wyzula-jan wyzula-jan changed the title refactor(heatmap): change device_name/entry to device/signal Change device_name/entry to device/signal Feb 16, 2026
@wyzula-jan wyzula-jan force-pushed the refactor/device-signal-names branch from 37c93d3 to 39913a4 Compare February 21, 2026 11:49
@wyzula-jan wyzula-jan force-pushed the refactor/device-signal-names branch from 39913a4 to aaef4c4 Compare February 21, 2026 14:04
@wyzula-jan wyzula-jan enabled auto-merge (rebase) February 22, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant