Change device_name/entry to device/signal#1049
Open
wyzula-jan wants to merge 1 commit intopre_release_v3from
Open
Change device_name/entry to device/signal#1049wyzula-jan wants to merge 1 commit intopre_release_v3from
wyzula-jan wants to merge 1 commit intopre_release_v3from
Conversation
0b85f8c to
89995ea
Compare
89995ea to
7dcc45f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the naming conventions for device-signal pairs throughout the bec_widgets codebase, changing from device_name/entry (or variants like x_device_name/x_device_entry) to device/signal (or device_x/signal_x, device_y/signal_y, etc.). This unifies the nomenclature according to the agreement in issue #1036. Additionally, "next_gen" suffixes are removed from test file names.
Changes:
- Renamed all device-signal pair parameters and properties from
*_name/*_entrytodevice_*/signal_*pattern - Updated model field names in
DeviceSignal,ScatterDeviceSignal,HeatmapDeviceSignal, andMotorConfig - Updated UI files (.ui) to reflect new widget naming
- Updated all tests, documentation, and RPC client stubs to match new naming
- Removed "next_gen" from test file names
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit_tests/test_waveform.py | Updated test assertions for DeviceSignal field names (name→device, entry→signal) |
| tests/unit_tests/test_scatter_waveform.py | Updated ScatterWaveform test parameter names and property assertions |
| tests/unit_tests/test_motor_map_next_gen.py | Renamed from "_next_gen", updated MotorConfig field names |
| tests/unit_tests/test_image_view_next_gen.py | Renamed from "_next_gen", updated Image widget parameter names |
| tests/unit_tests/test_heatmap_widget.py | Updated Heatmap parameter names and SafeProperty names |
| tests/unit_tests/test_curve_settings.py | Updated curve tree test parameter names |
| tests/end-2-end/*.py | Updated all e2e tests with new parameter names |
| docs/**/*.md | Updated documentation examples with new parameter names |
| bec_widgets/widgets/plots/waveform/* | Updated Waveform widget parameters, properties, and internal usage |
| bec_widgets/widgets/plots/scatter_waveform/* | Updated ScatterWaveform parameters, config fields, and properties |
| bec_widgets/widgets/plots/motor_map/* | Updated MotorMap config and parameters |
| bec_widgets/widgets/plots/image/* | Updated Image widget parameters and properties |
| bec_widgets/widgets/plots/heatmap/* | Updated Heatmap parameters, config, properties, and UI files |
| bec_widgets/cli/client.py | Updated RPC stub signatures |
| bec_widgets/widgets/containers/auto_update/auto_updates.py | Updated auto-update widget calls |
| bec_widgets/applications/views/view.py | Updated view widget parameter usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
171dfe8 to
37c93d3
Compare
37c93d3 to
39913a4
Compare
39913a4 to
aaef4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unify the naming conventions for device-signal pairs according to agreed in #1036. Additionally dropping "next_gen" from tests since there is only one version of the widget.
Related Issues
-closes #1036