Skip to content

Comments

fix(toggle): move toggle to theme colors#1058

Merged
wyzula-jan merged 1 commit intopre_release_v3from
fix/toggle_color
Feb 21, 2026
Merged

fix(toggle): move toggle to theme colors#1058
wyzula-jan merged 1 commit intopre_release_v3from
fix/toggle_color

Conversation

@wakonig
Copy link
Member

@wakonig wakonig commented Feb 21, 2026

Description

The toggle was using hard-coded colors. This PR moves them to proper theme colors.

Definition of Done

  • Documentation is up-to-date.

@wakonig wakonig self-assigned this Feb 21, 2026
@wakonig wakonig marked this pull request as ready for review February 21, 2026 12:43
Copilot AI review requested due to automatic review settings February 21, 2026 12:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves ToggleSwitch styling away from hard-coded RGB values toward application theme colors, so the widget better matches the rest of the themed UI.

Changes:

  • Read theme colors from QApplication.instance().theme during ToggleSwitch initialization.
  • Provide fallback QColor(...) defaults when no theme is present.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bec_widgets/widgets/utility/toggle/toggle.py 92.30% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@wyzula-jan wyzula-jan merged commit de93bec into pre_release_v3 Feb 21, 2026
35 checks passed
@wyzula-jan wyzula-jan deleted the fix/toggle_color branch February 21, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants