feat(devicebrowser): show enabled and readonly status#790
Open
feat(devicebrowser): show enabled and readonly status#790
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
deactivating device through widget first time (second time no error) triggers this error: (probably not related to this PR and it is general bug with DeviceBrowser) Traceback (most recent call last):
File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/utils/error_popups.py", line 126, in wrapper
return method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/widgets/services/device_browser/device_item/device_item.py", line 175, in _reload_config
self.set_display_config(self.dev[self.device]._config)
~~~~~~~~^^^^^^^^^^^^^
File "/Users/janwyzula/PSI/bec/bec_lib/bec_lib/devicemanager.py", line 100, in __getitem__
return super().__getitem__(item)
^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'samy' |
883b033 to
45f08d1
Compare
Contributor
Author
|
@wyzula-jan fixed that error, CI cross is just from the docs build timing out |
283423d to
c8b10d9
Compare
c8b10d9 to
5e5edad
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
5e5edad to
c170cc7
Compare
|
This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an icon (with tooltip) to show device enabled status and readonly status in the condensed form in the device browser. Fixes #788
Also fixes a bug where config is attempted to be reloaded while the device doesn't exist. ( Fixes #827 )