Conversation
Collaborator
|
hi @julianesiebourg , thanks a lot. could you please run |
idavydov
reviewed
Jul 9, 2024
…imize_multi_plate_design
idavydov
force-pushed
the
hotfix_plate_wrapper
branch
from
b746241 to
cedd39f
Compare
Collaborator
|
@julianesiebourg could you please check that it's still ok? I rebased everything. |
Collaborator
Author
|
What do we do with this mess now? @idavydov Do we still need the MR at all? Do we revoke my accidental commit to main? |
Collaborator
|
I think we reverted changes in the main branch, so if we want this to be implemented in the next version we should merge it. Does it work more reliably than the current version of the code, @julianesiebourg ? |
Collaborator
Author
|
I'll check again this afternoon and let you know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set p = 1, penalize_lines = "none" for plate scoring functions in optimize_multi_plate_design