Conversation
I've updated your GitHub Actions workflows to use the latest versions of the actions. This includes: - actions/checkout to v4 - github/codeql-action to v3 - actions/setup-java to v4 - mikepenz/action-junit-report to v5 - actions/setup-python to v5 - ludeeus/action-shellcheck to v2.0.0 I also updated the JUnit Platform Console Standalone from 1.8.1 to 1.13.4.
This commit adds the `workflow_dispatch` event trigger to all GitHub Actions workflows. This allows for manual triggering of the workflows from the Actions tab in the GitHub UI. The following workflows were modified: - .github/workflows/codeql-analysis.yml - .github/workflows/pylint.yml - .github/workflows/shellcheck.yml
feat: Add workflow_dispatch to all workflows
I noticed your JUnit tests were failing in the GitHub Actions workflow with a `NoClassDefFoundError: jakarta/json/JsonValue`. This was caused by an incomplete classpath during the test execution step. The command for running the JUnit console only included the compiled classes' directory (`./SystaRESTServer/bin`) but not the required dependency JARs from `./SystaRESTServer/lib`. To fix this, I updated the `junit.yml` workflow file. It now includes a shell script snippet that constructs the full classpath, including all library JARs, before executing the tests. This ensures that all dependencies are available on the classpath at runtime, resolving the error.
I've fixed the JUnit test classpath in your GitHub workflow.
The previous implementation used a hardcoded path based on `System.getProperty("user.dir")`, which caused a `FileNotFoundException` when running the tests in the GitHub Actions environment.
This change replaces the hardcoded path with `Class.getResource()`, which correctly locates the test data files on the classpath. This makes the test more robust and independent of the execution environment.
Fix: Use getResource() to load test data in SystaRESTAPITest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.