Merged
Conversation
4 tasks
freakboy3742
approved these changes
Dec 10, 2024
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
I've made some additional changes, allowing the initial pyscript.toml to come from the template. This allows us to adapt to any future "base configuration" changes in the template, rather than in code.
Marking as accepted since I'm happy with the changes; leaving to @mhsmith for a final cross-check and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all obsolete PyScript settings. Since these settings were required by the old template, also added a
platform_target_version.The corresponding template PR should be merged first:
PR Checklist: