Closed
Conversation
Draft to replace code loading pyscript.toml from the web-template files with a process to gather them from toga_web or 3rd party GUI toolkit
… finding _gather_backend_config_file function might be obsolete. This now attempts to find pyscript.toml in the same directory as config.toml using wheel.open()
Refactor wheel processing, simplify deploy/* checks, drop unused cases, and sort inserts/packages for consistent output
Refactor web static build to remove fragile type inference, apply all marker styles per file and streamline wheel processing
Refactor process_wheel method to restore legacy '/static' CSS insert handling and handle CSS files from both legacy and deploy/inserts paths. Adds a warning when legacy '/static' CSS is detected. All CSS files are now added to static/css/briefcase.css with banner comments.
first_app_built will not no longer contain it
…_config_backend_warning
Minor comment update warn on each legacy /static/*.css, not once per wheel
Create and update test_build__handle_legacy_css.py that houses the test cases for _handle_legacy_css method
Create and update test_build__handle_insert.py that houses the test cases for _handle_insert method
Log invalid insert files as warnings instead of debug in _handle_insert()
debugs have been changed to warning, monkey patch no longer necessary
Update static.rst to reflect the new web platform insert system and deployment config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation of the static.py to reflect the new web platform insert system and deployment configuration.
Addresses the missing documentation for the recently introduced asset-gathering strategy, which is currently not documented at all.
Refs #2337 , #2442
PR Checklist: