Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the production environment configuration by replacing the legacy API URL with two new environment variables that separate the base API URL from the domain URL.
- Replaced
VITE_API_URLwithVITE_BASE_URLandVITE_DOMAIN - Updated API endpoint from workers.dev subdomain to main domain
- Added explicit domain configuration for the RC store
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| VITE_BASE_URL=https://api.benhalverson.dev | ||
| VITE_DOMAIN=https://rc-store.benhalverson.dev No newline at end of file |
There was a problem hiding this comment.
The removal of VITE_API_URL and introduction of VITE_BASE_URL and VITE_DOMAIN suggests a significant refactoring of how API endpoints are configured. Ensure that all references to VITE_API_URL throughout the codebase have been updated to use the new variable names, and verify that the application logic correctly constructs URLs using these two separate values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.