Open
Conversation
Removes ~800 lines of internal React fiber traversal and stack-trace probing code in favor of the element-source npm package, which provides the same functionality with a simpler async API. Made-with: Cursor
|
@aidenybai is attempting to deploy a commit to the Benji Taylor's Projects Team on Vercel. A member of the Team first needs to authorize it. |
| "prepublishOnly": "pnpm build" | ||
| }, | ||
| "dependencies": { | ||
| "element-source": "^0.0.3" |
There was a problem hiding this comment.
this package is 7 years old contains one relevant function:
let getReactDebugSource = function (element: any) {
for (var key in element) {
if (key.startsWith('__reactInternalInstance$')) {
return element[key]._debugSource;
}
}
return null;
}There was a problem hiding this comment.
I mean IMO this dependency is not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.