Support for connecting to IPv6 peers and setting peer Ports #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 addresses given to -peers are now handled in a way that prevents conflict between net.IP (which wants the address without brackets) and net.Dial (which requires brackets). Ports can now also be added so it is possible to connect to peer not listening on the default port.
Owner
|
Looks good to me, thank you! I'll give this a test later and if it works I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small patch that allows IPv6 addresses to be used as peers. This is currently prevented due to a conflict between net.IP (which wants the address without brackets) and net.Dial (which requires brackets).
Also modified the way peers are parsed to allow a port to be added so it becomes possible to connect to a peer not listening on the default port. Due to the way net.IP and net.SplitHostPort work this does cause the somewhat confusing situation that IPv6 addresses without a port are only accepted without brackets, but addresses with a port require them.