Open
Conversation
CasparKielwein
force-pushed
the
qt6_support
branch
from
cb15005 to
47b6282
Compare
Author
|
I tried to maintain compatibility with the currently supported version by using pre-compiler switches. |
Contributor
|
Why don't you go with the one line |
In the CMakeLists.txt add a branch to check of qt6 is available. If it is, use that, otherwise assume QT5. In qfsignalproxy slightly adapt call to constructor of QVariant. QVariant(type, void*) signature has changed between QT5 and QT6. in qfstore adapt call to constructor of QQmlListProperty. Signature has changed between QT5.13 and QT6
CasparKielwein
force-pushed
the
qt6_support
branch
from
47b6282 to
8fd171a
Compare
Author
I was not aware of this option and changed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the CMakeLists.txt add a branch to check of qt6 is available.
If it is, use that, otherwise assume QT5.
In qfsignalproxy slightly adapt call to constructor of QVariant.
QVariant(type, void*) signature has changed between QT5 and QT6.
change deprecated call to QQmlListProperty(..)