Completed assignment with changes and updates after RSpec feedback#9
Open
bennettatoms wants to merge 2 commits intohw_w02_d02_rspecfrom
Open
Completed assignment with changes and updates after RSpec feedback#9bennettatoms wants to merge 2 commits intohw_w02_d02_rspecfrom
bennettatoms wants to merge 2 commits intohw_w02_d02_rspecfrom
Conversation
Collaborator
|
Looks good, minus a few organization points. Let's talk at break and organize it a little better. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
completeness: 5ish (couldn't test for method in grocery_list... see question)
comfortability: 5
questions: "If you have a class that initializes by importing from a file, is there a way to test methods in that class without creating an artificial file and trying to pass it in? Was having trouble with that one."
}