separate section for hidden quesions added#107
separate section for hidden quesions added#107AvinashAgarwal14 wants to merge 1 commit intoberkmancenter:devfrom
Conversation
| noOfHiddenQues += 1; | ||
| }); | ||
| if(noOfHiddenQues > 0) | ||
| return true; |
There was a problem hiding this comment.
You could return true from inside the loop when you get the first hidden question.
That would make it more efficient and faster as in that case comparatively lesser number of iterations would be required.
This could affect the time complexity and efficiency of code drastically when there are larger number of hidden questions.
|
In general, this feature is not important because the hidden questions are already present with a clear distinction. Moreover, the hidden questions are not visible in the presentation mode. This has already been implemented. |
|
Actually this would help, especially for mods and admins. If a question is hidden the mods and admins should not have to slug through the greyed out hidden questions to find the non-hidden ones scattered through out. This would simplify the work flow of anyone having to moderate an instance by bringing visible questions more to the front.
|
@okpop Thank you, are there any changes that I should make with respect to this PR? |
|
For now no.
|
@okpop I felt so because even in the current scenario, all the hidden questions are placed after the non-hidden ones. The non-hidden ones are not scattered throughout. Although I agree that creating a separate section might simplify the work flow even further. |
18c4e1e to
4167cce
Compare
Fixes: #106

Before:
After:
