Skip to content

Conversation

@dbnski
Copy link

@dbnski dbnski commented Apr 22, 2016

This pull request resolves two problems:

  1. RT::Handle forces utf8 encoding on the RT database connection, so ExternalAuth::DBI MUST do the same since it does not perform on-the-fly character set conversion. Otherwise RT database may throw errors when non-utf8 characters are present in queries (e.g. accented characters in RealName field), or we may end up writing garbled text into RT tables.
  2. New RT introduced DatabaseExtraDSN, but the module currently does not respect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant