Skip to content

Comments

Add HGLRC_F722_S board#995

Open
HGLRC-T wants to merge 7 commits intobetaflight:masterfrom
HGLRC-T:HGLRC_F722_S
Open

Add HGLRC_F722_S board#995
HGLRC-T wants to merge 7 commits intobetaflight:masterfrom
HGLRC-T:HGLRC_F722_S

Conversation

@HGLRC-T
Copy link
Contributor

@HGLRC-T HGLRC-T commented Dec 27, 2025

image

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

Warning

Rate limit exceeded

@HGLRC-T has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 53b5f06 and 4664d78.

📒 Files selected for processing (1)
  • configs/HGLRC_F722_S/config.h

Walkthrough

Adds a new board configuration header configs/HGLRC_F722_S/config.h for the HGLRC_F722_S (STM32F7X2). Declares MCU/board/manufacturer; enables ICM42688P accel/gyro, DPS310 baro, M25P16 flash, MAX7456 OSD; maps GPIO/TIMER/UART/I2C/SPI/ADC, sets defaults (blackbox=flash, current/voltage scaling, gyro/yaw alignment). (39 words)

Changes

Cohort / File(s) Summary
New HGLRC_F722_S board configuration
configs/HGLRC_F722_S/config.h
Added board config header: sets MCU/board/manufacturer; enables ICM42688P accel & gyro, DPS310 barometer, M25P16 flash, MAX7456 OSD; defines beeper, motor, LED strip pins and TIMER_PIN_MAPPING; configures UART/I2C/SPI/ADC pins & instances; enables ADC1_DMA_OPT; sets MAG/BARO I2C device, default blackbox=flash, current/voltage meter sources/scaling, gyro alignment, and default board yaw alignment.

Sequence Diagram(s)

(Skipped — configuration header only; no multi-component control flow to diagram.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Add JHEF722PRO #891 — Adds a new STM32F7 board configuration header with the same sensors/peripherals (ICM42688P, DPS310, M25P16, MAX7456) and overlapping pin/macro mappings.

Suggested labels

Awaiting prototype samples

Suggested reviewers

  • osirisinferi
  • haslinghuis

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the required template structure with all mandatory sections (Review Requirements, Hardware Compliance, Housekeeping, Checklist), but the submitter has not filled in actual PR details—only the template guidance text remains. Replace the template placeholder text with specific details about this board (manufacturer, hardware features, testing status, etc.) and check the completed checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title "Add HGLRC_F722_S board" directly and clearly summarizes the main change: adding a new flight controller board configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@osirisinferi
Copy link
Contributor

I think you also accidentally included the initial commit for the HGLRC_F405_S board, which is already covered in #987.

@haslinghuis haslinghuis added the Partner Program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 31, 2025
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 4, 2026

I have fixed it based on your feedback and used git rebase and forced push. I hope all like it.

Co-authored-by: Osiris Inferi <github@flut.nl.eu.org>
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other HGLRC targets don't use underscore in their names.

@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 5, 2026

Other HGLRC targets don't use underscore in their names.

Yes, we previously used uppercase letters for connections, but we found that this wasn't very clear. Therefore, starting in the second half of 2025, we hope that new targets will use underscores for connections, which will improve user recognition of target files.

HGLRC-T and others added 3 commits January 6, 2026 10:39
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 13, 2026

Let's merge it~

@ot0tot
Copy link
Contributor

ot0tot commented Jan 13, 2026

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Please update the checklist

@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Jan 14, 2026

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Please update the checklist

Will do these things according to the rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner Program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants