Skip to content

Conversation

@rparrett
Copy link
Contributor

@rparrett rparrett commented Feb 13, 2025

Objective

Update typos, fix new typos.

1.29.6 was just released to fix an issue where January's corrections were not included in the binaries for the last release.

Reminder: typos can be tossed in the monthly non-critical corrections issue.

Solution

I chose to allow implementors, because a good argument seems to be being made here and there is now a PR to address that.

Discussion

Should I exclude bevy_mikktspace?

At one point I think we had an informal policy of "don't mess with mikktspace until #9050 is merged" but it doesn't seem like that is likely to be merged any time soon.

I think these particular corrections in mikktspace are fine because

  • The same typo mistake seems to have been fixed in that PR
  • The entire file containing these corrections was deleted in that PR

Typo of the Month

correspindong -> corresponding

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Code-Quality A section of code that is hard to understand or change labels Feb 13, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 13, 2025
Merged via the queue into bevyengine:main with commit 2760692 Feb 13, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants