Fix window freezing when dragged or resized on Windows #18004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloucks
force-pushed
the
issue-17488-window-freezes-on-drag-or-resize
branch
from
e2713b9 to
1449687
Compare
IceSentry
added
A-Windowing
IceSentry
approved these changes
Feb 23, 2025
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
I confirm this works on my windows 11 machine too.
mockersf
approved these changes
Feb 23, 2025
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
I don't have a windows to test it works, but the fix looks like what I expected
Member
|
As discussed with @alice-i-cecile it would be nice to get this fix in a patch. |
aevyrie
approved these changes
Feb 23, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Feb 24, 2025
# Objective Fixes #17488 ## Solution The world update logic happened in the the `about_to_wait` winit window callback, but this is is not correct as (1) the winit documentation states that the callback should not be used for that purpose and (2) the callback is not fired when the window is resized or being dragged. However, that callback was used in #11245 to fix an iOS bug (which caused the regression). The solution presented here is a workaround until the event loop code can be re-written. ## Testing I confirmed that the `eased_motion` example continued to be animated when dragging or resizing the window. https://github.com/user-attachments/assets/ffaf0abf-4cd7-479b-83e9-e1850aaf3513
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 2, 2025
# Objective Fixes #18027 ## Solution Run `redraw_requested` logic in `about_to_wait` on Windows during initial application startup and when in headless mode ## Testing - Ran `cargo run --example window_settings` to demonstrate invisible window creation worked again and fixes #18027 - Ran `cargo run --example eased_motion` to demonstrate no regression with the fix for #17488 Ran all additional `window` examples. Notes: - The `transparent_window` was not transparent but this appears to have been broken prior to #18004. See: #7544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17488
Solution
The world update logic happened in the the
about_to_waitwinit window callback, but this is is not correct as (1) the winit documentation states that the callback should not be used for that purpose and (2) the callback is not fired when the window is resized or being dragged. However, that callback was used in #11245 to fix an iOS bug (which caused the regression). The solution presented here is a workaround until the event loop code can be re-written.Testing
I confirmed that the
eased_motionexample continued to be animated when dragging or resizing the window.window_drag_resize.mp4