limit number of open files on macOS and iOS #22560
Open
+57
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Assets
alice-i-cecile
added
the
S-Needs-Review
andriyDev
reviewed
Jan 17, 2026
Contributor
There was a problem hiding this comment.
I'm a little nervous to do this: you could end up with every running loader acquiring a single file, but then needing a second file to complete, and then being deadlocked.
It's unclear whether this is better than just failing to load. I guess so since it's less likely that users have 128 assets that also need a second file load to complete (e.g., an immediate load). Though having 128 gltfs that reference other textures isn't completely impossible.
| root_path, | ||
| #[cfg(all( | ||
| feature = "multi_threaded", | ||
| any(target_os = "macos", target_os = "ios") |
Contributor
There was a problem hiding this comment.
We should also be doing this on Linux. I believe Linux's default is 1024.
Contributor
|
Also this doesn't take into consideration multiple asset sources. This might need to be a global semaphore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
FileAssetReader, and to Apple OSesAssetMode::Processedcauses some assets to fail to load #14542bistroscene on macOS gives errors in the log, and some texture are randomly not loaded:Solution
Semaphoreto ensure we're not opening more than 128 files in parallelTesting
cargo run --release --package bistroworks without errors in the log