[Merged by Bors] - A hack to work around minimising still being broken #4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
added
C-Bug
DJMcNab
removed
the
P-High
mockersf
approved these changes
Apr 15, 2022
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
# Objective - #4098 still hasn't fixed minimisation on Windows. - `Clusters.lights` is assumed to have the number of items given by the product of `Clusters.dimensions`'s axes. ## Solution - Make that true in `clear`.
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - bevyengine#4098 still hasn't fixed minimisation on Windows. - `Clusters.lights` is assumed to have the number of items given by the product of `Clusters.dimensions`'s axes. ## Solution - Make that true in `clear`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - bevyengine#4098 still hasn't fixed minimisation on Windows. - `Clusters.lights` is assumed to have the number of items given by the product of `Clusters.dimensions`'s axes. ## Solution - Make that true in `clear`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Clusters.lightsis assumed to have the number of items given by the product ofClusters.dimensions's axes.Solution
clear.