zTalkBox Updates #716

AARJL · 2026-01-04T20:47:07Z

Made small cosmetic changes for empty space and neatness
Moved reset_auto_wait to lower down the file
Changed "unsigned long" to "size_t" for ztalkbox::load
ztalkbox::load_settings(xIniFile& ini) at 95%, seems to be missing a string but could not solve in scratch
read_bool to 99%, not sure how to fix the issue with the negative and positive arrays
parse_tag_trap to 99%, I could get to 100% when the if statements are triple nested and goto is used. Might be a better way.
reset_tag_sound, reset_tag_trap, reset_tag_allow_quit, trigger_allow_quit, trigger_auto_wait all done at 100%
wait_context& wait_context::operator=(const wait_context& rhs)... yeah....
stop_audio_effect to 32%, still working on this
reset_auto_wait, reset_tag_auto_wait, and trigger_trap at 100%
Added various offsets in zTalkBox.h
Added struct sound_context in zTalkBox.h

…o used code formmatting tool

github-actions · 2026-01-04T20:48:28Z

`main/SB/Game/zTalkBox`

	Section	From	To	Bytes
📈	`.rodata`	0.00%	15.29%	+69
📈	`.sdata2`	0.00%	42.86%	+13
📈	`.text`	13.36%	20.27%	+994

	Function	From	To	Bytes
✅	`@unnamed@zTalkBox_cpp@::read_bool(const substr&, bool)`	0.00%	100.00%	+188
✅	`@unnamed@zTalkBox_cpp@::reset_auto_wait()`	2.22%	100.00%	+176
✅	`@unnamed@zTalkBox_cpp@::reset_tag_auto_wait(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+112
✅	`@unnamed@zTalkBox_cpp@::trigger_auto_wait(const xtextbox::jot&)`	0.00%	100.00%	+56
✅	`@unnamed@zTalkBox_cpp@::reset_tag_sound(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::reset_tag_allow_quit(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::trigger_allow_quit(const xtextbox::jot&)`	0.00%	100.00%	+40
📈	`@unnamed@zTalkBox_cpp@::parse_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	99.63%	+107
✅	`@unnamed@zTalkBox_cpp@::reset_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
📈	`@unnamed@zTalkBox_cpp@::stop_audio_effect()`	0.00%	32.14%	+27
📈	`ztalkbox::load_settings(xIniFile&)`	0.00%	95.96%	+95

JoshSanch

Nice progress :)

Left some feedback so we can work to get this in a merge-ready state.

JoshSanch · 2026-01-05T02:11:34Z

src/SB/Game/zTalkBox.cpp

 }

-void ztalkbox::load(xBase& data, xDynAsset& asset, unsigned long)
+void ztalkbox::load(xBase& data, xDynAsset& asset, size_t)


Is there a reason you made this change? It differs from the signature in objdiff which already matched:
ztalkbox::load(xBase&, xDynAsset&, unsigned long)

I think I made this change because at some point I was asked to use the types.h file when defining variables as signed or unsigned. I guess this does not apply to function signatures.

Ah I see - good instincts then, but we don't want to use size_t in this instance. Use lowercase u32 instead. size_t has a specific semantic meaning wherein it is the size the particular CPU architecture uses for iterator variables in bits. Since this argument isn't used as an iterator for a loop or anything, u32 is more appropriate.

This article is a solid discussion on size_t to reference: https://www.embedded.com/why-size_t-matters/

JoshSanch · 2026-01-05T02:14:25Z

src/SB/Game/zTalkBox.cpp

+void ztalkbox::load_settings(xIniFile& ini) //TODO
+{
+    shared.volume = xIniGetFloat(&ini, "talk_box.volume", 2.0f);
+    xDebugAddTweak("Talk Box|\u{1}Globals|volume", &shared.volume, 0.1f, 10.0f, NULL, NULL, 0);


Objdiff displays literal characters a little strange - we haven't figured out yet why these particular strings are this way but this is probably a better match for this one:

Suggested change

xDebugAddTweak("Talk Box|\u{1}Globals|volume", &shared.volume, 0.1f, 10.0f, NULL, NULL, 0);

xDebugAddTweak("Talk Box|\01Globals|volume", &shared.volume, 0.1f, 10.0f, NULL, NULL, 0);

I made the change but no change in objdiff.

Let's prefer the changed code but share in the Discord somehow so we can help you finish the match. Might just be that the string data memory location is off but the actual code matches.

JoshSanch · 2026-01-05T02:15:10Z

src/SB/Game/zTalkBox.cpp

    ((ztalkbox&)data).load((const ztalkbox::asset_type&)asset);
 }

+void ztalkbox::load_settings(xIniFile& ini) //TODO


No need to leave these TODO comments - objdiff and our reporting tooling will show these as not matching 100% so it's redundant here.

I left these in by mistake, they were for me when I was coding to remember what I was doing. I will remove them along with the DONE comments.

JoshSanch · 2026-01-05T02:16:07Z

src/SB/Game/zTalkBox.cpp

+
 namespace
 {
+    static U8 read_bool(const substr& s, bool def) //TODO 99%


Same comment as earlier here - no need for the TODO.

JoshSanch · 2026-01-05T02:19:03Z

src/SB/Game/zTalkBox.cpp

+    static U8 read_bool(const substr& s, bool def) //TODO 99%
+    {
+        extern const substr negative[6];
+        extern const substr positive[6];


These are definitely not extern - you can see in objdiff that there's data for these two arrays within the file. Please work with the Discord to figure these ones out.

Yeah I see this but was not sure what to make of it. I will reach out in Discord. Given that I can't seem to use decomp.me for this function due to namespacing issues, what is the best way to get help with that? Most of zTalkBox is in an anonymous namespace and that makes it difficult to reach out for help using that tool.

Might be a vc screenshare or just sharing pics as we go. I have some thoughts already since it'll have some form like:

Suggested change

extern const substr positive[6];

const substr positive[6] = {

{"string1", 1},

...

};

JoshSanch · 2026-01-05T02:24:24Z

src/SB/Game/zTalkBox.cpp

+        shared.auto_wait.query = Q_SKIP;
+    }
+    static void reset_tag_auto_wait(xtextbox::jot& j, const xtextbox&, const xtextbox& ctb,
+                                    const xtextbox::split_tag&) //DONE


Please remove the DONE comment in line with the other review comments.

JoshSanch · 2026-01-05T02:24:38Z

src/SB/Game/zTalkBox.cpp

    *(U16*)&this->type = 0;
 }
+
+static U8 trigger_trap(const xtextbox::jot& j) //DONE


Please remove the DONE comment in line with the other review comments.

JoshSanch · 2026-01-05T02:25:56Z

src/SB/Game/zTalkBox.h

+            ACTION_SET = 0,
+            ACTION_PUSH = 1,
+            ACTION_POP = 2,


When enums start at 0 and increment by one, we leave them implicitly defined to avoid visual noise. Opt for this instead, please:

Suggested change

ACTION_SET = 0,

ACTION_PUSH = 1,

ACTION_POP = 2,

ACTION_SET,

ACTION_PUSH,

ACTION_POP,

For these I simply copy and pasted from the dwarf file. I will go ahead and make the changes for all enums from here.

JoshSanch · 2026-01-05T02:26:16Z

src/SB/Game/zTalkBox.h

+            TYPE_INVALID = 0,
+            TYPE_VOLUME = 1,
+            TYPE_TARGET = 2,
+            TYPE_ORIGIN = 3,


Apply general enum styling feedback from the other one here as well, please

JoshSanch · 2026-01-05T02:26:22Z

src/SB/Game/zTalkBox.h

+            SOURCE_MEMORY = 0,
+            SOURCE_STREAM = 1,


Apply general enum styling feedback from the other one here as well, please

AARJL · 2026-01-05T02:58:12Z

Any comment on wait_context& wait_context::operator=(const wait_context& rhs) ?

I am not sure why it didn't show up as a change here, but we briefly went over this during our VC and I was asked to include it in my next PR to go over it. Line 501

JoshSanch · 2026-01-05T03:28:28Z

Any comment on wait_context& wait_context::operator=(const wait_context& rhs) ?

I am not sure why it didn't show up as a change here, but we briefly went over this during our VC and I was asked to include it in my next PR to go over it. Line 501

I'm going to spend some time seeing if I can get this to match on my own.

github-actions · 2026-01-05T03:55:10Z

`main/SB/Game/zTalkBox`

	Section	From	To	Bytes
📈	`.rodata`	0.00%	15.48%	+70
📈	`.sdata2`	0.00%	42.86%	+13
📈	`.text`	13.36%	18.96%	+806

	Function	From	To	Bytes
✅	`@unnamed@zTalkBox_cpp@::reset_auto_wait()`	2.22%	100.00%	+176
✅	`@unnamed@zTalkBox_cpp@::reset_tag_auto_wait(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+112
✅	`@unnamed@zTalkBox_cpp@::trigger_auto_wait(const xtextbox::jot&)`	0.00%	100.00%	+56
✅	`@unnamed@zTalkBox_cpp@::reset_tag_sound(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::reset_tag_allow_quit(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::trigger_allow_quit(const xtextbox::jot&)`	0.00%	100.00%	+40
📈	`@unnamed@zTalkBox_cpp@::parse_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	99.63%	+107
✅	`@unnamed@zTalkBox_cpp@::reset_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
📈	`@unnamed@zTalkBox_cpp@::stop_audio_effect()`	0.00%	32.14%	+27
📈	`ztalkbox::load_settings(xIniFile&)`	0.00%	95.96%	+95

AARJL · 2026-01-05T03:58:44Z

read_bool went to 0% when trying to make changes to it, I'll work with the team on that.

github-actions · 2026-01-05T04:54:39Z

`main/SB/Game/zTalkBox`

	Section	From	To	Bytes
📈	`.rodata`	0.00%	15.48%	+70
📈	`.sdata2`	0.00%	42.86%	+13
📈	`.text`	13.36%	20.27%	+994

	Function	From	To	Bytes
✅	`@unnamed@zTalkBox_cpp@::read_bool(const substr&, bool)`	0.00%	100.00%	+188
✅	`@unnamed@zTalkBox_cpp@::reset_auto_wait()`	2.22%	100.00%	+176
✅	`@unnamed@zTalkBox_cpp@::reset_tag_auto_wait(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+112
✅	`@unnamed@zTalkBox_cpp@::trigger_auto_wait(const xtextbox::jot&)`	0.00%	100.00%	+56
✅	`@unnamed@zTalkBox_cpp@::reset_tag_sound(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::reset_tag_allow_quit(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
✅	`@unnamed@zTalkBox_cpp@::trigger_allow_quit(const xtextbox::jot&)`	0.00%	100.00%	+40
📈	`@unnamed@zTalkBox_cpp@::parse_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	99.63%	+107
✅	`@unnamed@zTalkBox_cpp@::reset_tag_trap(xtextbox::jot&, const xtextbox&, const xtextbox&, const xtextbox::split_tag&)`	0.00%	100.00%	+64
📈	`@unnamed@zTalkBox_cpp@::stop_audio_effect()`	0.00%	32.14%	+27
📈	`ztalkbox::load_settings(xIniFile&)`	0.00%	95.96%	+95

AARJL and others added 7 commits December 21, 2025 17:46

Matched 10 small functions

b79fc69

ztalkbox load and state_type update

1c48385

Made suggested changes for primative types and updated variables. als…

9ef4f04

…o used code formmatting tool

Merge branch 'bfbbdecomp:main' into main

bd48ce3

Merge remote-tracking branch 'upstream/main'

30db20c

Merge branch 'main' of https://github.com/AARJL/bfbb

634562c

Update

da22f62

JoshSanch requested changes Jan 5, 2026

View reviewed changes

Made suggested updates

9785b64

Reverted read_bool back to the state it was at

ae0fe8a

	xDebugAddTweak("Talk Box\|\u{1}Globals\|volume", &shared.volume, 0.1f, 10.0f, NULL, NULL, 0);
	xDebugAddTweak("Talk Box\|\01Globals\|volume", &shared.volume, 0.1f, 10.0f, NULL, NULL, 0);

-        extern const substr positive[6];
+        const substr positive[6] = {
+            {"string1", 1},
+            ...
+        };

zTalkBox Updates #716

Are you sure you want to change the base?

zTalkBox Updates #716

Uh oh!

Conversation

AARJL commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

main/SB/Game/zTalkBox

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AARJL commented Jan 5, 2026

Uh oh!

JoshSanch commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

main/SB/Game/zTalkBox

Uh oh!

AARJL commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

main/SB/Game/zTalkBox

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`main/SB/Game/zTalkBox`

`main/SB/Game/zTalkBox`

`main/SB/Game/zTalkBox`