-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CodeQL support #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duranserkan
wants to merge
20
commits into
bigskysoftware:dev
Choose a base branch
from
duranserkan:CodeQLSupport
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CodeQL support #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Nomini to alternatives.md
…late fragments (bigskysoftware#3576) Add Askama to the list of template engines that support fragments
Author
|
I followed the checklist and targeted dev, but because I branched from master, it looks like many unrelated commits were included. Would you prefer I rebase this onto dev, or will you squash merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces CodeQL, a SAST (Static Application Security Testing) tool. Unlike standard linters, it performs taint analysis over the AST (Abstract Syntax Tree) to detect security vulnerabilities with a much higher degree of confidence.
I have confirmed that this action runs correctly on my fork, so it should be safe to merge.
Running SAST scans on commits and PRs is a security best practice, so I strongly recommend integrating this and fixing the findings. I consider this change a security-related bug fix for your CI workflow.
I use this exact workflow in another repository of mine. You can safely check the run logs here to verify that the configuration is valid and effective:
https://github.com/duranserkan/DRN-Project/actions/runs/20662690492/workflow
https://github.com/duranserkan/DRN-Project/actions/runs/20662690492/job/59328518670
Corresponding issue: #3620 Enable CodeQL SAST Workflow
Testing
The workflow has been verified and functions correctly. You can check the implementation branch and the successful run logs here:
Branch: https://github.com/duranserkan/htmx/tree/CodeQLSupport
Run Logs: https://github.com/duranserkan/htmx/actions/runs/20876809796/job/59987410482"
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded