Skip to content

Conversation

@ColmTalbot
Copy link
Collaborator

Updated the GitHub Actions workflow to trigger on push events and added a new job for publishing to TestPyPI.

Closes #978

Updated the GitHub Actions workflow to trigger on push events and added a new job for publishing to TestPyPI.
@ColmTalbot ColmTalbot requested a review from mj-will November 3, 2025 15:24
Added conditions to restrict publishing to specific repository and handle local version stripping for TestPyPI.
@ColmTalbot
Copy link
Collaborator Author

Looks like this is successfully pushing now, it will attempt to push to test.pypi for any push to bilby-dev/bilby. We should be more careful about people making branches on this fork to avoid overloading testpypi. If there is too much of a load on testpypi and we can't reduce the number of pushes, we can try setting up a different upload point.

@mj-will
Copy link
Collaborator

mj-will commented Nov 3, 2025

@ColmTalbot does this mean the PyPI uploads now happen when the tag is made rather than when the release is made? If so, we should update the docs.

@ColmTalbot
Copy link
Collaborator Author

does this mean the PyPI uploads now happen when the tag is made rather than when the release is made? If so, we should update the docs.

I guess technically yes, I can make the check if: github.event_name == 'release' && github.event.action == 'published' to keep the same behaviour. We should really be doing them together though.

@ColmTalbot ColmTalbot deployed to test-release November 3, 2025 19:46 — with GitHub Actions Active
@mj-will
Copy link
Collaborator

mj-will commented Nov 4, 2025

I guess technically yes, I can make the check if: github.event_name == 'release' && github.event.action == 'published' to keep the same behaviour. We should really be doing them together though.

Perhaps we should just remove the documentation for making tags from the terminal, that way we guide people towards always making them together?

release:
types: [published]

on: push
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow needs to be triggered on release.

@ColmTalbot ColmTalbot marked this pull request as draft November 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use test.pypi.org for testing packaging changes

3 participants