feat: add client-side telnet protocol support#96
Open
billchurch wants to merge 3 commits intomainfrom
Open
Conversation
Add protocol awareness to the SolidJS client so the same codebase
serves both SSH and telnet connections. The server injects
`protocol: 'telnet'` into window.webssh2Config for telnet routes.
Changes:
- Add ProtocolType ('ssh' | 'telnet') to config types and protocol
signal to terminal store
- Read protocol from injected config in app.tsx on mount
- Make Socket.IO path dynamic (/telnet/socket.io vs /ssh/socket.io)
- Guard hostkey event handlers (SSH-only, skipped for telnet)
- LoginModal: show telnet warning banner, hide SSH key upload,
passphrase, keyboard-interactive; default port 23; relax
credential validation (password optional for telnet)
- Hide SFTP file browser and host key UI for telnet connections
- Update session footer to show telnet:// prefix when appropriate
- S3776: extract buildHostPortPayload/buildCredentialPayload helpers to reduce cognitive complexity from 20 to under 15 - S6853: replace sr-only labels with aria-label attributes on inputs (SonarLint false positive for SolidJS `for` vs React `htmlFor`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtocolType('ssh' | 'telnet') to config types andprotocolsignal to terminal store/telnet/socket.iovs/ssh/socket.io) based on protocoltelnet://prefix for telnet connectionsCompanion to billchurch/webssh2#490.
Test plan
/telnet/socket.iofor telnet,/ssh/socket.iofor SSH