nl_bridge: do not try to flush fdb on removed interfaces#487
Merged
Conversation
rubensfig
requested changes
Mar 4, 2026
When removing a VLAN from a bridge port, we flush the fdb entries from the kernel. When removing a port form the bridge, we also remove all VLANs from that port. When we try to flush the fdb for that port, the kernel refuses to do so since the port is not a bridge member anymore, and returns an error, causing baseboxd to treat this as fatal. Since removing a port from a bridge will automatically delete all fdb entries for all vlans, there is no need for us to manually delete them, so skip flushing the fdb if we are in the interface removal path, i.e. new_link is a nullptr. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_no_flush_on_bridge_removal
branch
from
d3bf84d to
47f1c6f
Compare
rubensfig
approved these changes
Mar 4, 2026
Contributor
rubensfig
left a comment
rubensfig
left a comment
There was a problem hiding this comment.
Tested on AG7648, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing a VLAN from a bridge port, we flush the fdb entries from the kernel. When removing a port form the bridge, we also remove all VLANs from that port.
When we try to flush the fdb for that port, the kernel refuses to do so since the port is not a bridge member anymore, and returns an error, causing baseboxd to treat this as fatal.
Since removing a port from a bridge will automatically delete all fdb entries for all vlans, there is no need for us to manually delete them, so skip flushing the fdb if we are in the interface removal path, i.e. new_link is a nullptr.