Replaced getServerRam with getServerUsedRam and getServerMaxRam#18
Open
stoltzld wants to merge 1 commit intobitburner-official:masterfrom
Open
Replaced getServerRam with getServerUsedRam and getServerMaxRam#18stoltzld wants to merge 1 commit intobitburner-official:masterfrom
stoltzld wants to merge 1 commit intobitburner-official:masterfrom
Conversation
Replaced getServerRam with getServerUsedRam and getServerMaxRam and converted a 2 dimensional array into 2 separate variables.
FastPlayer1234
approved these changes
Jan 23, 2025
FastPlayer1234
left a comment
FastPlayer1234
left a comment
There was a problem hiding this comment.
Does the same as the original just using the new commands instead of the depreciated command.
FastPlayer1234
suggested changes
Jan 23, 2025
FastPlayer1234
left a comment
FastPlayer1234
left a comment
There was a problem hiding this comment.
do variable names in camel case instead of all lowercase. the rest of the variable names in this document are camel case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced getServerRam with getServerUsedRam and getServerMaxRam and converted a 2 dimensional array into 2 separate variables.