fix esm import compatibility issue#48
Conversation
|
I ran the workflow and it gave errors. You should look at the errors (lts unit, coverage, and gitdiff) and figure out why they gave errors and fix them. Pull Requests should not cause CI errors. I was merely telling you that this repository's CI config might be outdated, so feel free to modify the CI config to fix any CI issues. Some people are big sticklers about PRs touching CI config (because you can easily just make the job command return true without actually fixing the underlying issue)... but I was saying "I'll go ahead and let you do that if necessary, I don't mind" CI can run on your fork btw. You would make, for instance, two branches, branch A and B. Then you make a pull request on your fork merging B into A. Then you can run the CI as much as you want without waiting for me to approve it. Then once all the errors are gone, you can then create a pull request to merge B into the master branch of our repo. |
fix #47