fix esm import compabitlity issue#50
Closed
maerzhase wants to merge 2 commits intobitcoinjs:masterfrom
Closed
Conversation
maerzhase
changed the title
Member
|
I'll leave the issue open, but this PR is broken. We'll consider this for the next major release, but the addition of ESM was a major breaking release to begin with, so anyone switching to use ESM will just have to deal with the new API quirks until the next major release. |
|
Hi @junderw, is there an ETA for the fix? |
|
any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #47
@junderw i tried what you said with creating a PR on my own fork but there are no workflows being run there maerzhase#1 (sorry if its a config issue on my end, but i have limited time to spend on this repo :) )
sorry if it feels cumbersome for you—not very straight forward to contribute a simple fix here.