Skip to content

fix: Return response error, in case of 403 status #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpusok wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix: Return response error, in case of 403 status #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion autocodesign/devportalclient/appstoreconnect/appstoreconnect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,15 @@ func NewRetryableHTTPClient(logger log.Logger, tracker Tracker) *http.Client {

if resp != nil && resp.StatusCode == http.StatusForbidden {
var apiError *ErrorResponse
if ok := errors.As(checkResponse(logger, resp), &apiError); ok {
respErr := checkResponse(logger, resp)
if ok := errors.As(respErr, &apiError); ok {
if apiError.IsRequiredAgreementMissingOrExpired() {
logger.Warnf("Received error FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED (status 403), retrying request...")
return true, nil
}
}
// return error, otherwise response will be read twice and appear empty
return false, respErr
}

if resp != nil && resp.StatusCode == http.StatusTooManyRequests {
Expand Down
Loading