fix: use correct starting function for child_spec/1#38
Open
Gazler wants to merge 1 commit intobitwalker:mainfrom
Open
fix: use correct starting function for child_spec/1#38Gazler wants to merge 1 commit intobitwalker:mainfrom
Gazler wants to merge 1 commit intobitwalker:mainfrom
Conversation
Previously, the `child_spec/1` function referenced a non-existent run
function. This would mean that a child spec such as:
{HashRing.Managed, [name: :foo]}
Would not work, instead requiring the start function to be explicitly
specified:
{HashRing.Managed, [name: :foo, start: {HashRing.Managed, :new, [:foo, []]}]}
This commit uses the `new/2` function instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Previously, the
child_spec/1function referenced a non-existent run function. This would mean that a child spec such as:Would not work, instead requiring the start function to be explicitly specified:
This commit uses the
new/2function instead.Checklist
There is no changelog?