[PM-25937] Simplify get_login_method method

[dani-garcia]

🎟️ Tracking

📔 Objective

Update get_login_method to return UserLoginMethod directly. This method was never available to SM so all its callers had to unnecessarly match and unwrap it every single time. Also remove the Arc in preparation of the SDK hydration epic, as that will deserialize/clone the values every time anyway.

🚨 Breaking Changes

[claude]

Claude finished @dani-garcia's task in 2m 55s —— View job

---

Pull Request Review: PM-25937 Simplify get_login_method method

Reviewed commit: aa7ed256 (re-review after merge of main)

Previous review: 455c45d0 -- approved with no findings

Re-Review Result

No PR-specific files changed since the previous review. The only new commit (aa7ed256) is a merge of main into the branch, bringing in unrelated changes (criterion dep update, sync for key-rotation, set_communication_type). None of these affect the 6 files modified in this PR.

The previous analysis remains valid:

• Security: No concerns. Cryptographic operations unchanged.
• Correctness: Behavior preserved across all 8 call sites.
• Breaking changes: None. All modified types are pub(crate).
• Performance: Acceptable trade of Arc clone for UserLoginMethod clone on non-hot paths.

✅ Approved -- no findings. Previous review still applies.

[github-actions]

Checkmarx One – Scan Summary & Details – 1e87cb9a-3e4e-4265-b1c1-6b4af9ca3665

Great job! No new security vulnerabilities introduced in this pull request

[github-actions]

🔍 SDK Breaking Change Detection Results

SDK Version: ps/PM-25937-simplify-get-login-method (aa7ed25)
Completed: 2026-02-16 15:10:50 UTC
Total Time: 248s

Client	Status	Details
typescript	✅ No breaking changes detected	TypeScript compilation passed with new SDK version - View Details

---

Breaking change detection completed. View SDK workflow

[codecov]

Codecov Report

❌ Patch coverage is 74.57627% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.27%. Comparing base (c4534ab) to head (aa7ed25).

Files with missing lines	Patch %	Lines
crates/bitwarden-core/src/client/internal.rs	66.66%	5 Missing ⚠️
...es/bitwarden-core/src/platform/get_user_api_key.rs	0.00%	5 Missing ⚠️
...rates/bitwarden-core/src/auth/password/validate.rs	85.00%	3 Missing ⚠️
crates/bitwarden-core/src/key_management/crypto.rs	88.88%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   81.25%   81.27%   +0.01%     
==========================================
  Files         316      316              
  Lines       36369    36354      -15     
==========================================
- Hits        29553    29545       -8     
+ Misses       6816     6809       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud