Skip to content

[PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl#810

Open
quexten wants to merge 4 commits intomainfrom
km/key-connector-url-decrypt-option
Open

[PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl#810
quexten wants to merge 4 commits intomainfrom
km/key-connector-url-decrypt-option

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Mar 4, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30584

📔 Objective

Adds the user init crypto method key-connector-url, which directly gets the key-connector-key within the SDK. This gets us closer to dropping the master-key support entirely in clients.

🚨 Breaking Changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Logo
Checkmarx One – Scan Summary & Detailsf167c6b9-e169-458c-9ed3-f53aa149f7c3

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten force-pushed the km/key-connector-url-decrypt-option branch from 4450335 to ee947cb Compare March 4, 2026 13:52
@quexten quexten changed the title km/key connector url decrypt option Add UserInitCryptoMethod::KeyConnectorUrl Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: km/key-connector-url-decrypt-option (19a9ada)
Completed: 2026-03-05 11:23:09 UTC
Total Time: 249s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (f8a75af) to head (19a9ada).

Files with missing lines Patch % Lines
crates/bitwarden-core/src/key_management/crypto.rs 0.00% 17 Missing ⚠️
...tes/bitwarden-crypto/src/keys/key_connector_key.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.06%     
==========================================
  Files         344      344              
  Lines       41116    41142      +26     
==========================================
  Hits        33623    33623              
- Misses       7493     7519      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten changed the title Add UserInitCryptoMethod::KeyConnectorUrl [PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl Mar 5, 2026
@quexten quexten marked this pull request as ready for review March 5, 2026 11:11
@quexten quexten requested review from a team as code owners March 5, 2026 11:11
@quexten quexten requested a review from eligrubb March 5, 2026 11:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant