Draft
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
iinuwa
force-pushed
the
iinuwa/add-prf-parsing
branch
2 times, most recently
from
ca4f77b to
ad2a87a
Compare
This does not enable PRF extension processing for vault items, but enables us to use this library for using device auth key passkeys.
iinuwa
force-pushed
the
iinuwa/add-prf-parsing
branch
from
ad2a87a to
882aa37
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 81.77% 82.36% +0.58%
==========================================
Files 344 344
Lines 41116 41401 +285
==========================================
+ Hits 33623 34099 +476
+ Misses 7493 7302 -191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-33111
📔 Objective
As part of the device auth key initiative, we need to be able to parse PRF input from the incoming make credential and get assertion requests. This adds types to parse the data from the extensions without having to parse the JSON manually.
Note that this enables parsing PRF input, but the authenticator is not evaluating PRF input on vault items. A follow-up PR will use the passkey-rs library to evaluate PRF input for the device auth key only.
(This PR also opens the door for supporting other extensions, like
largeBlob.)🚨 Breaking Changes
This changes the type of
extensionsfields on theMakeCredentialRequestandGetAssertionRequeststructs toOption<MakeCredentialExtensionInputs>andOption<GetAssertionExtensionInputs>. (It also adds anextensionsfield to bothMakeCredentialResultandGetAssertionResult, but that should be non-breaking as it should only be read from clients.)However, these were previously
Option<String>, and we do not support any extensions, so this is set tonilin the iOS client (the only consumer, currently). So no client code changes should be required.